-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat (sink: aws_cloudwatch_logs) #11185: Allow specifying a KMS key and tags for newly created AWS CloudWatch log groups. #22274
Merged
pront
merged 7 commits into
vectordotdev:master
from
johannesfloriangeiger:11185-aws_cloudwatch_logs-sink-kms-key-tags
Jan 27, 2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated AWS CloudWatch log groups.
github-actions
bot
added
domain: sinks
Anything related to the Vector's sinks
domain: ci
Anything related to Vector's CI environment
labels
Jan 22, 2025
pront
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise, this looks good and thank you for adding tests.
github-actions
bot
added
the
domain: external docs
Anything related to Vector's external, public documentation
label
Jan 24, 2025
neko-dd
approved these changes
Jan 24, 2025
website/cue/reference/components/sinks/base/aws_cloudwatch_logs.cue
Outdated
Show resolved
Hide resolved
pront
reviewed
Jan 24, 2025
pront
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs team left a comment. Otherwise, LGTM
johannesfloriangeiger
changed the title
#11185: Allow specifying a KMS key and tags for newly created AWS CloudWatch log groups.
feat (sink: aws_cloudwatch_logs) #11185: Allow specifying a KMS key and tags for newly created AWS CloudWatch log groups.
Jan 26, 2025
pront
approved these changes
Jan 27, 2025
Merged
via the queue into
vectordotdev:master
with commit Jan 27, 2025
f151cab
87 of 88 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
domain: ci
Anything related to Vector's CI environment
domain: external docs
Anything related to Vector's external, public documentation
domain: sinks
Anything related to the Vector's sinks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the feature request #11185 by allowing users to specify a KMS key and tags for AWS CloudWatch log group sinks that are being used when creating new groups.
Change Type
Is this a breaking change?
How did you test this PR?
$KMS_KEY
with the ARN of the key created in the previous step.vector --config ./vector.yaml
, see 3 new log groups being created: One without both custom KMS key and tags, one with only tags and one with both custom KMS key and tags.Key policy that allows the usage in log groups in
us-east-1
:vector.yaml
Does this PR include user facing changes?
Checklist
make check-all
is a good command to run locally. This check isdefined here. Some of these
checks might not be relevant to your PR. For Rust changes, at the very least you should run:
cargo fmt --all
cargo clippy --workspace --all-targets -- -D warnings
cargo nextest run --workspace
(alternatively, you can runcargo test --all
)Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References